Update value_counts to return correct name in pandas 2.0#9919
Merged
jrbourbeau merged 3 commits intodask:mainfrom Feb 6, 2023
Merged
Update value_counts to return correct name in pandas 2.0#9919jrbourbeau merged 3 commits intodask:mainfrom
value_counts to return correct name in pandas 2.0#9919jrbourbeau merged 3 commits intodask:mainfrom
Conversation
jrbourbeau
reviewed
Feb 6, 2023
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @j-bennet! Just one minor comment, but overall this looks good
|
|
||
| @pytest.mark.skipif(not PANDAS_GT_110, reason="dropna implemented in pandas 1.1.0") | ||
| def test_value_counts_with_normalize_and_dropna(): | ||
| @pytest.mark.parametrize("normalize", [True, False]) |
Member
There was a problem hiding this comment.
Thanks for taking the time expand test coverage here
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
jrbourbeau
approved these changes
Feb 6, 2023
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
This looks great, thanks @j-bennet
value_counts, resulting series name changed, pandas 2.0 compatibilityvalue_counts to return correct name in pandas 2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for an upstream failure:
In pandas 2.0, the result Series produced by
value_counts()has a different name.See https://pandas.pydata.org/docs/dev/whatsnew/v2.0.0.html#value-counts-sets-the-resulting-name-to-count.
Xref #9736.
Xref pandas-dev/pandas#49912.
pre-commit run --all-files