Additional updates for detecting a distributed scheduler #9890
Merged
jrbourbeau merged 2 commits intodask:mainfrom Jan 27, 2023
Merged
Additional updates for detecting a distributed scheduler #9890jrbourbeau merged 2 commits intodask:mainfrom
distributed scheduler #9890jrbourbeau merged 2 commits intodask:mainfrom
Conversation
Member
Author
|
For reference, these are the test failures this PR is fixing I'll plan to merge this PR after CI finishes so it can be included in the release later today |
4 tasks
Member
Author
|
Going to go ahead and merge this so we can get the release out (all the macOS machines are currently occupied). This issue isn't mac-specific and was impacting other OS builds too. Given linux and windows builds have already passed, I have confidence this issue is also solved on macOS. EDIT: I also ran those two test locally on my mac and they both passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following dask/distributed#7482 we're no longer using the config system to say that a
distributedscheduler is available. Almost all of the relevant changes needed here were included in #9808. This PR includes two similar updates (only noticed these because I saw related tests beginning to fail onmain).cc @fjetter for visibility