Fix assigning Series to column when ddf.columns.min() raises#9485
Merged
jrbourbeau merged 1 commit intodask:mainfrom Sep 13, 2022
Merged
Fix assigning Series to column when ddf.columns.min() raises#9485jrbourbeau merged 1 commit intodask:mainfrom
ddf.columns.min() raises#9485jrbourbeau merged 1 commit intodask:mainfrom
Conversation
Member
Author
|
Well that's a weird test failure. |
jrbourbeau
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ddf[col] = swas raising when the column name types can't be compared such as when they are a mix of strings and integers.I'm surprised this edge case hasn't been caught and fixed earlier.
Closes #xxxxpre-commit run --all-files