Skip to content

Update da.linalg.solve for SciPy 1.9.0 compatibility #9350

Merged
jrbourbeau merged 11 commits intodask:mainfrom
pavithraes:scipy-1.9.0
Aug 5, 2022
Merged

Update da.linalg.solve for SciPy 1.9.0 compatibility #9350
jrbourbeau merged 11 commits intodask:mainfrom
pavithraes:scipy-1.9.0

Conversation

@pavithraes
Copy link
Copy Markdown
Member

@pavithraes pavithraes commented Aug 4, 2022 •
edited
Loading

TODO before closing:

@pavithraes pavithraes marked this pull request as draft August 4, 2022 12:54
@github-actions github-actions Bot added the array label Aug 4, 2022
@pavithraes pavithraes self-assigned this Aug 4, 2022
@github-actions github-actions Bot added the documentation Improve or add to documentation label Aug 4, 2022
pavithraes
pavithraes commented Aug 4, 2022
View reviewed changes
Comment thread dask/array/linalg.py Outdated
pavithraes
pavithraes commented Aug 4, 2022
View reviewed changes
Comment thread dask/array/linalg.py Outdated
@pavithraes pavithraes removed the documentation Improve or add to documentation label Aug 4, 2022
@github-actions github-actions Bot added the documentation Improve or add to documentation label Aug 4, 2022
jrbourbeau
jrbourbeau reviewed Aug 4, 2022
View reviewed changes
Comment thread docs/source/conf.py
Comment thread dask/array/linalg.py Outdated
Comment thread dask/array/linalg.py Outdated
@pavithraes pavithraes marked this pull request as ready for review August 4, 2022 18:07
@pavithraes pavithraes requested a review from jrbourbeau August 4, 2022 18:37
jrbourbeau
jrbourbeau reviewed Aug 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pavithraes! Just a few final comments, overall this looks really close

Comment thread dask/array/linalg.py Outdated
Comment thread dask/array/linalg.py Outdated
Comment thread dask/array/tests/test_linalg.py Outdated
Comment thread dask/array/linalg.py Outdated
Comment thread dask/array/linalg.py Outdated
pavithraes and others added 5 commits August 5, 2022 17:27
@pavithraes @jrbourbeau
be specific about keyword sym_pos
9c9cc48 
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
@pavithraes @jrbourbeau
specify sym_pos kwarg
a6707f0 
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
@pavithraes
remove NotImplemented error, and raise DeprecationWarning when sym_po…
94183c3 
…s=False
@pavithraes
use warnings.warn instead of raises
2a1f365
@pavithraes
remove unnecessary else
f3d557d
This was referenced Aug 5, 2022
Open
Open
jrbourbeau
jrbourbeau approved these changes Aug 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pavithraes! This looks good to go

I pushed one small commit to change the DeprecationWarning we were raising to a FutureWarning as this warning is meant for end users as opposed to developers. Hope that's okay

@jrbourbeau jrbourbeau merged commit 386b475 into dask:main Aug 5, 2022
@pavithraes pavithraes deleted the scipy-1.9.0 branch August 5, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrbourbeau jrbourbeau jrbourbeau approved these changes

Assignees

@pavithraes pavithraes

Labels

array documentation Improve or add to documentation upstream

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SciPy 1.9.0 compatibility

2 participants

@pavithraes @jrbourbeau