Fix: support pathlib.PurePath in normalize_token#9229
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
pavithraes
reviewed
Jul 5, 2022
Member
|
@agoose77 Thanks for this PR, it looks good! The lining CI failure can be fixed by merging |
Member
|
add to allowlist |
Contributor
Author
|
Thanks all. Not sure how that |
Member
|
Thanks @agoose77! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dask.base.tokenizedoes not produce the same string for repeat invocations on the same path. This is because the tokenizer defaults to the object tokenizer.This PR registers the identity function for the
pathlib.PurePathtype. I believe this is reasonable, as the default str / repr is a good description of the path. I'm not a Dask expert, though, so there may be reasons that an explicit tokenization is better.I haven't profiled the startup-time change by importing
pathlib, but I assume we're not worrying about that here.pre-commit run --all-files