Conversation
ian-r-rose
reviewed
Jun 29, 2022
| :doc:`delayed` yielding None | ||
| """ | ||
| if split_every is None: | ||
| # FIXME https://github.com/python/typeshed/issues/5074 |
Collaborator
There was a problem hiding this comment.
Was this special-cased in mypy? I don't see any linked issues in the above. In any event, nice to remove type: ignores
Collaborator
Author
There was a problem hiding this comment.
The annotation was originally numbers.Number | Literal[False] | None.
Since in type annotations (and in type annotations only) int is a subclass of float, I simplified it, but I forgot to remove the # type: ignore.
ian-r-rose
approved these changes
Jun 29, 2022
Collaborator
ian-r-rose
left a comment
There was a problem hiding this comment.
Took a look at this with @pavithraes, and it looks good. Thanks!
Member
|
Thanks @crusaderky! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors dask/distributed#6601 and dask/distributed#6606.
Note that I omitted
disallow_incomplete_defsas it would have costed more time than what I'm happy spending right now - something for a future iteration.