Skip to content

Add missing append in delayed best practices example#9202

Merged
jrbourbeau merged 1 commit intodask:mainfrom
beduncs:fix-delayed-best-practices-docs
Jun 21, 2022
Merged

Add missing append in delayed best practices example#9202
jrbourbeau merged 1 commit intodask:mainfrom
beduncs:fix-delayed-best-practices-docs

Conversation

@beduncs
Copy link
Copy Markdown
Contributor

@beduncs beduncs commented Jun 21, 2022

Updated code block in delayed best practices docs

  • added appending result to the results list before return in Break up computations into many pieces Do
  • added appending result to the results list before return in Break up computations into many pieces Don't

@GPUtester
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@github-actions github-actions Bot added the documentation Improve or add to documentation label Jun 21, 2022
@jrbourbeau jrbourbeau changed the title docs: added missing append in delayed-best-practices example code Add missing append in delayed best practices example Jun 21, 2022
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benjaminhduncan -- this is in

Also, I noticed this is your first code contribution to this repository. Welcome!

@jrbourbeau jrbourbeau merged commit 0820983 into dask:main Jun 21, 2022
@beduncs beduncs deleted the fix-delayed-best-practices-docs branch June 22, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improve or add to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants