Update logos page in docs#9167
Conversation
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @scharlottej13!
Does anyone know if these logos were used outside this docs page? I didn't see any mention elsewhere in dask/dask.
There's also the marketing.dask.org page. See https://marketing.dask.org/en/latest/logos.html for the section about logos.
I don't think we have an updated equivalent for with padding (they are all "no pad"). Will this be an issue?
My sense is this won't be a big issue. But cc @jacobtomlinson @jsignell for thoughts
|
Thank you @jrbourbeau!
I think marketing.dask.org is getting a new home at |
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for the info @scharlottej13. I opened dask/marketing#13 to see if we should go ahead and archive the dask/marketing repo then.
I left one minor comment, otherwise this looks good to go
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
| .. image:: images/dask_stacked_white.svg | ||
| :alt: Dask logo. | ||
| .. image:: images/dask_horizontal_on_blue.svg | ||
| :alt: Dask logo to use on a blue background. |
There was a problem hiding this comment.
This is kind of unrelated, but the janelia logo below seems out of place. I think we should just remove it from this page.
There was a problem hiding this comment.
Sounds good, I'll remove it. Do we need to include it elsewhere? I'm not too familiar with the context of this logo.
There was a problem hiding this comment.
I think keeping it in the assets and just not having it on this page makes sense.
jacobtomlinson
left a comment
There was a problem hiding this comment.
I think ultimately we need to get the designers to add the logos to the style guide page on the main website and then redirect this docs page over there.
But this is nice to have in the meantime.
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @scharlottej13. Merging as the docs build has finished and the changes here don't impact tests
|
The branding is here https://www.dask.org/brand-guide. I'm not sure how this page helps https://www.dask.org/style-guide |
Ah, my mistake! Since we have https://www.dask.org/brand-guide, should we do a redirect instead? (sorry @jacobtomlinson if that's what you meant in your earlier comment). Mistakes to fix (if we choose to keep this page):
|
|
Yup looks like /style-guide was the wrong link and we should be directing to /brand-guide. Sorry about that. I'll update the cloudflare rules tomorrow. cc @jsignell |
pre-commit run --all-filesUpdate logos page in Dask docs (see #9160 for more context).
Does anyone know if these logos were used outside this docs page? I didn't see any mention elsewhere in dask/dask.
I don't think we have an updated equivalent for with padding (they are all "no pad"). Will this be an issue?