Make is_monotonic work when some partitions are empty#8897
Merged
jrbourbeau merged 3 commits intodask:mainfrom Apr 11, 2022
Merged
Make is_monotonic work when some partitions are empty#8897jrbourbeau merged 3 commits intodask:mainfrom
is_monotonic work when some partitions are empty#8897jrbourbeau merged 3 commits intodask:mainfrom
Conversation
jcrist
reviewed
Apr 7, 2022
| else: | ||
| data = x if is_index_like(x) else x.iloc | ||
| data = [[x.is_monotonic_increasing, data[0], data[-1]]] | ||
| return pd.DataFrame(data=data, columns=["monotonic", "first", "last"]) |
Member
There was a problem hiding this comment.
This will default to object dtype for all columns, does this have any adverse affects in the aggregate function? From reading the code I'd guess this would result in all columns being promoted to object dtype during concatenation, which may be undesired.
Member
Author
There was a problem hiding this comment.
Oh good point! I just did a little test and it looks like the dtype of the columns after concatenation is not object. I'm not 100% sure how this works. But I did try calling .is_monotonic on a series with dtype=object, and it throws a warning before coercing to numeric, so we would know if that were happening.
jrbourbeau
reviewed
Apr 8, 2022
jrbourbeau
reviewed
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files