Use dask config extension from dask-sphinx-theme#8751
Merged
jrbourbeau merged 2 commits intodask:mainfrom Feb 24, 2022
Merged
Conversation
jrbourbeau
reviewed
Feb 23, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @quasiben. I think we'll want to update our minimum dask-sphinx-theme version here too
dask/docs/requirements-docs.txt
Line 3 in e3b3259
Member
Author
|
Definitely, I'll update once there is a new release |
Member
|
Version |
Member
|
I've pushed a commit to bump that version, hope that's ok @quasiben. |
dask-sphinx-theme
jrbourbeau
approved these changes
Feb 24, 2022
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jacobtomlinson. This LGTM, will merge after CI finishes
phobson
pushed a commit
to phobson/dask
that referenced
this pull request
Feb 28, 2022
Co-authored-by: Jacob Tomlinson <jtomlinson@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesRemoves the the sphinx extensions and instead relies on the extension coming from the dask-sphinx-theme. This PR can only be merged after dask/dask-sphinx-theme#64 and a new dask-sphinx-theme is released
cc @jacobtomlinson @ayushdg