Remove < 2.0 Faraday version restriction#1415
Merged
Merged
Conversation
> 2.0 Faraday version restriction
> 2.0 Faraday version restriction< 2.0 Faraday version restriction
Closed
Member
|
You've got CI running properly now, looks like its got some failing tests in the gitlab side |
Contributor
Author
|
not sure if I understand the errors. Are the other gems broken due to this change? |
Member
|
I dont know much about web mock - but maybe it also uses faraday and by allowing for the pdated faraday it breaks webmock? |
oleg-vinted
reviewed
Jan 20, 2023
oleg-vinted
left a comment
There was a problem hiding this comment.
As for the test failures, they also happen in current master when using Ruby 3.2. So they seem to be caused by #1411.
| spec.add_runtime_dependency "colored2", "~> 3.1" | ||
| spec.add_runtime_dependency "cork", "~> 0.1" | ||
| spec.add_runtime_dependency "faraday", ">= 0.9.0", "< 2.0" | ||
| spec.add_runtime_dependency "faraday", ">= 0.9.0", "~> 2.0.0" |
There was a problem hiding this comment.
This version constraint doesn't make much sense as the second part makes the first one redundant. You probably want ">= 0.9.0", "< 3.0"
Member
|
Thanks folks - I dropped 3.2 from CI, so this should be fine I think |
Member
|
Shipped as 9.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to allow Faraday 2.0.0.
Locking between versions of ">= 0.9.0", "< 2.0" was causing new projects to have dependency conflicts.
Related: #1349