Fix offenses for RuboCop that can be fixed automatically#1406
Merged
Conversation
ef6798a to
f39b009
Compare
ydah
commented
Nov 20, 2022
| def initialize(dangerfile) | ||
| super(dangerfile) | ||
| raise unless dangerfile.env.scm.instance_of?(Danger::GitRepo) | ||
| raise unless dangerfile.env.scm.class == Danger::GitRepo # rubocop:disable Style/ClassEqualityComparison |
Contributor
Author
There was a problem hiding this comment.
Addressing this offense would change the behavior.
It actually causes the test to fail, so it is disabled: https://github.com/danger/danger/actions/runs/3508633313/jobs/5877172874
``` `Lint/UselessAssignment: Exclude` in `.rubocop.yml` overrides a generated `Exclude` in `.rubocop_todo.yml`. Either remove `Lint/UselessAssignment: Exclude` or add `inherit_mode: merge: - Exclude`. Created .rubocop_todo.yml. ```
f39b009 to
573d46c
Compare
Member
|
Looks good to me, given it a few reads though and everything seems reasonable to me- thanks (sorry for the months of delay!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix offenses for RuboCop that can be fixed automatically.
The automatic modification performed in this PR is performed by
rubocop -a.In the process, I also implement the following:
Removed RuboCop version specification so that the latest RuboCop can be used.
This is because using the latest version will prevent false positive offenses and erroneous automatic corrections.
The newly added cops is not currently working.
This is because the purpose of this PR is to address the current violations of RuboCop, not the newly added cops.
Ref: https://docs.rubocop.org/rubocop/versioning.html#enablingdisabling-pending-cops-in-bulk
Add inherit_mode for
merge: Exclude.The following warnings have been addressed:
For those that cannot be modified automatically, they are once put into todo status in
.rubocop_todo.yml.I would like to check these as well if this PR is merged.