Run GitHub Actions workflow on macOS, Ubuntu and Windows#1381
Merged
Conversation
46286d3 to
9a81090
Compare
mathroule
commented
Sep 1, 2022
| TOKEN+='79960c12a1e067f2ec' | ||
| DANGER_GITHUB_API_TOKEN=$TOKEN RUNNING_IN_ACTIONS=true echo 'bundle exec danger --verbose' | ||
| - name: Running the Dangerfile for this repo | ||
| if: runner.os != 'Windows' |
Member
Author
There was a problem hiding this comment.
Skip these commands on Windows, since it does not work. This should work on Windows:
set TOKEN=7469b4e94ce21b43e3ab7a
set TOKEN=%TOKEN%79960c12a1e067f2ec
set DANGER_GITHUB_API_TOKEN=%TOKEN%
set RUNNING_IN_ACTIONS=true
bundle exec danger --verboseBy the way Danger is not properly run on CI, the command is only displayed with the echo instead of being run.
Member
There was a problem hiding this comment.
ha, oh dear. Well, this shouldn't block your PR.
Member
|
OK, I've removed the webhooks for AppVeyor, so this should be some of the last builds over there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use GitHub Actions matrix to run checks on macOS, Ubuntu and Windows.
Changes
masterbranch