Drop support for Ruby 2.4, support Ruby 2.7+#1378
Conversation
0b26698 to
aee9ca1
Compare
e3b1426 to
ae6a6e7
Compare
Kaspik
left a comment
There was a problem hiding this comment.
LGTM, soudn good. We should add support (tests) for 3.0+ too.
Danger is tested against Ruby 3.+ on GitHub Actions: https://github.com/danger/danger/blob/master/.github/workflows/CI.yml#L10 I updated the CircleCI config file, but Danger appears to be not built anymore on this platform. |
|
@orta could you please help with the AppVeyor project settings? |
|
I think we can skip AppVeyor completely as we moved to Github Actions? |
I'm not against merging the PR as is. But it's just a matter of changing an option in AppVeyor to keep the compatibility with it. |
|
Updated to VS 2022 - we have the appveyor for testing windows compat, dropping that is OK if we check on windows using GitHub Actions 👍🏻 |
|
This'll have to be a semver major bump alas |
|
Cool, I've carved out some time to go through all this tomorrow 👍🏻 |
Require Ruby version 2.7+. Ruby 2.6 has reached end of life: https://www.ruby-lang.org/en/downloads/branches. This change is a prerequisite to #1377.
Changes:
AppVeyor project configuration needs to be changed to use Visual Studio 2022 (or at least 2019) to support Ruby 2.7 (https://www.appveyor.com/docs/windows-images-software/#ruby).
