Skip to content

Update Octokit gem dependency to version 5.x#1377

Merged
orta merged 2 commits into
danger:masterfrom
zendesk:bump-octokit-to-version-5
Sep 2, 2022
Merged

Update Octokit gem dependency to version 5.x#1377
orta merged 2 commits into
danger:masterfrom
zendesk:bump-octokit-to-version-5

Conversation

@mathroule

@mathroule mathroule commented Aug 22, 2022

Copy link
Copy Markdown
Member

Danger relies on Octokit gem dependency version ~> 4.7, which makes it impossible to use Octokit version 5.0 and above when dependencies are resolved with Bundler.

@mathroule mathroule requested a review from orta August 22, 2022 14:06
@mathroule mathroule force-pushed the bump-octokit-to-version-5 branch from 89fb951 to 7432a6e Compare August 22, 2022 14:07
@mathroule mathroule changed the title Update Octokit dependency to version 5.0 Update Octokit dependency to version 5.x Aug 22, 2022
@mathroule mathroule force-pushed the bump-octokit-to-version-5 branch from b977ecd to 7432a6e Compare August 22, 2022 14:47
@mathroule

mathroule commented Aug 22, 2022

Copy link
Copy Markdown
Member Author

Since Octokit drops support for Ruby version below 2.7: https://github.com/octokit/octokit.rb/releases/tag/v5.0.0.
This PR is not building: https://ci.appveyor.com/project/orta/danger-47jiu/builds/44541423.

Since Ruby 2.6 has reached end of life, does it makes sense to migrate Danger to require at least Ruby 2.7, like done in #1225 for Ruby 2.4?

@mathroule

mathroule commented Aug 22, 2022

Copy link
Copy Markdown
Member Author

Since Octokit drops support for Ruby version below 2.7: https://github.com/octokit/octokit.rb/releases/tag/v5.0.0. This PR is not building: https://ci.appveyor.com/project/orta/danger-47jiu/builds/44541423.

Since Ruby 2.6 has reached end of life, does it makes sense to migrate Danger to require at least Ruby 2.7, like done in #1225 for Ruby 2.4?

This PR requires #1378.

@mathroule mathroule changed the title Update Octokit dependency to version 5.x Update Octokit gem dependency to version 5.x Aug 22, 2022
@Kaspik

Kaspik commented Sep 2, 2022

Copy link
Copy Markdown
Member

@mathroule Please merge master in 🙏🏼

@orta orta merged commit a628c2a into danger:master Sep 2, 2022
@mathroule mathroule deleted the bump-octokit-to-version-5 branch September 2, 2022 15:01
@mathroule mathroule restored the bump-octokit-to-version-5 branch September 2, 2022 15:01
@orta

orta commented Sep 2, 2022

Copy link
Copy Markdown
Member

Thanks, I had to merge this manually - this has just shipped as 9.0.0!

@Kaspik

Kaspik commented Sep 2, 2022

Copy link
Copy Markdown
Member

Can we also publish release for 9.0? 🙏🏼

@orta

orta commented Sep 2, 2022

Copy link
Copy Markdown
Member

That's what I meant: https://rubygems.org/gems/danger

@Kaspik

Kaspik commented Sep 2, 2022

Copy link
Copy Markdown
Member

Ohh I meant Github :)

@mathroule

Copy link
Copy Markdown
Member Author

Thanks for the release 9.0.0. I updated the GitHub releases section accordingly: https://github.com/danger/danger/releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants