Skip to content

Fix can't modify frozen String (FrozenError) exception for VSTS / Azure DevOps#1376

Merged
orta merged 1 commit into
danger:masterfrom
yanniks:master
Sep 2, 2022
Merged

Fix can't modify frozen String (FrozenError) exception for VSTS / Azure DevOps#1376
orta merged 1 commit into
danger:masterfrom
yanniks:master

Conversation

@yanniks

@yanniks yanniks commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

On recent Ruby versions, it does not seem to be possible to directly use gsub! as Danger did it before in the VSTS / Azure DevOps component:

bundle exec danger --dangerfile=../buildtools/Dangerfile
[08:46:08]: ▸ bundler: failed to load command: danger (/Users/ci/.gem/ruby/2.6.0/bin/danger)
[08:46:08]: ▸ /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/lib/danger/request_sources/vsts.rb:198:in `gsub!': can't modify frozen String (FrozenError)
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/lib/danger/request_sources/vsts.rb:198:in `block in submit_inline_comments_for_kind!'
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/lib/danger/request_sources/vsts.rb:190:in `reject'
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/lib/danger/request_sources/vsts.rb:190:in `submit_inline_comments_for_kind!'
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/lib/danger/request_sources/vsts.rb:156:in `submit_inline_comments!'
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/lib/danger/request_sources/vsts.rb:97:in `update_pull_request!'
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/lib/danger/danger_core/dangerfile.rb:264:in `post_results'
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/lib/danger/danger_core/dangerfile.rb:292:in `run'
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/lib/danger/danger_core/executor.rb:29:in `run'
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/lib/danger/commands/runner.rb:73:in `run'
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/claide-1.1.0/lib/claide/command.rb:334:in `run'
[08:46:08]: ▸ from /Users/ci/.gem/ruby/2.6.0/gems/danger-8.6.1/bin/danger:5:in `<top (required)>'

We were facing this issue on a Mac Studio with macOS 12.5. This PR fixes the issue.

@orta

orta commented Sep 2, 2022

Copy link
Copy Markdown
Member

Seems reasonable to me, thanks!

@orta orta merged commit 66dd426 into danger:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yanniks @orta