Skip to content

fix: make "New Spec File" a button link style#15835

Merged
brian-mann merged 1 commit intodevelopfrom
fix/add-new-specs-button
Apr 7, 2021
Merged

fix: make "New Spec File" a button link style#15835
brian-mann merged 1 commit intodevelopfrom
fix/add-new-specs-button

Conversation

@brian-mann
Copy link
Copy Markdown
Member

@brian-mann brian-mann commented Apr 6, 2021

User facing changelog

  • Changed style of "New Spec File" to be a link style instead of a primary button

How has the user experience changed?

The previous style was way too aggressive to be a primary button, and distracted from the already existing primary button (which was the browser dropdown).

image

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@brian-mann brian-mann requested a review from a team as a code owner April 6, 2021 23:57
@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Apr 6, 2021

Thanks for taking the time to open a PR!

@brian-mann brian-mann added the type: enhancement Requested enhancement of existing feature label Apr 6, 2021
@brian-mann brian-mann changed the title make "New Spec File" a button link style, cleanup code fix: make "New Spec File" a button link style Apr 6, 2021
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 7, 2021



Test summary

4020 0 49 2Flakiness 0


Run details

Project cypress
Status Passed
Commit 41b4611
Started Apr 7, 2021 2:10 AM
Ended Apr 7, 2021 2:21 AM
Duration 10:15 💡
OS Linux Debian - 10.8
Browser Chrome 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@brian-mann brian-mann merged commit 065446f into develop Apr 7, 2021
@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Apr 7, 2021

Released in 7.0.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.1, please open a new issue.

@cypress-bot cypress-bot Bot locked as resolved and limited conversation to collaborators Apr 7, 2021
@jennifer-shehane jennifer-shehane deleted the fix/add-new-specs-button branch August 28, 2025 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: enhancement Requested enhancement of existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants