Skip to content

fix: do not watch specs on run mode#22060

Merged
estrada9166 merged 2 commits intodevelopfrom
alejandro/fix/early-return-spec-watcher-run-mode
Jun 2, 2022
Merged

fix: do not watch specs on run mode#22060
estrada9166 merged 2 commits intodevelopfrom
alejandro/fix/early-return-spec-watcher-run-mode

Conversation

@estrada9166
Copy link
Copy Markdown
Contributor

@estrada9166 estrada9166 commented Jun 2, 2022

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Jun 2, 2022

Thanks for taking the time to open a PR!

@estrada9166 estrada9166 marked this pull request as ready for review June 2, 2022 19:23
@estrada9166 estrada9166 requested a review from tgriesser as a code owner June 2, 2022 19:23
@estrada9166 estrada9166 requested a review from mjhenkes June 2, 2022 19:43
@cypress
Copy link
Copy Markdown

cypress Bot commented Jun 2, 2022 •
edited
Loading


Test summary

4377 • 0 • 49 • 0 • Flakiness 1

Run details
Project cypress
Status Passed
Commit fb66ea3
Started Jun 2, 2022 8:06 PM
Ended Jun 2, 2022 8:19 PM
Duration 12:48 💡
OS Linux Debian - 10.11
Browser Electron 100

View run in Cypress Dashboard ➡️

Flakiness

cypress/e2e/cypress/proxy-logging.cy.ts 1 Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@estrada9166 estrada9166 merged commit e170d5d into develop Jun 2, 2022
@estrada9166 estrada9166 deleted the alejandro/fix/early-return-spec-watcher-run-mode branch June 2, 2022 20:14
tgriesser added a commit that referenced this pull request Jun 2, 2022
@tgriesser
Merge branch 'tgriesser/fix/change-typescript-detection-rules' of git…
6ccecf2 
…hub.com:cypress-io/cypress into tgriesser/fix/change-typescript-detection-rules

* 'tgriesser/fix/change-typescript-detection-rules' of github.com:cypress-io/cypress:
  fix: do not watch specs on run mode (#22060)
  fix: #22038 support esm import for windows (#22042)
  fix: Change ffmpeg to post process at priority 20 (#21587)
@mjhenkes mjhenkes linked an issue Jun 2, 2022 that may be closed by this pull request
Cypress 10 watch all files when executing cypress run #22054
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgriesser tgriesser tgriesser approved these changes

@mjhenkes mjhenkes Awaiting requested review from mjhenkes

+1 more reviewer

@ZachJW34 ZachJW34 ZachJW34 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cypress 10 watch all files when executing cypress run

3 participants

@estrada9166 @tgriesser @ZachJW34