fix: changes to correct typescript detection behavior#22058
Merged
fix: changes to correct typescript detection behavior#22058
Conversation
Contributor
|
Thanks for taking the time to open a PR!
|
mjhenkes
reviewed
Jun 2, 2022
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
mjhenkes
reviewed
Jun 2, 2022
…hub.com:cypress-io/cypress into tgriesser/fix/change-typescript-detection-rules * 'tgriesser/fix/change-typescript-detection-rules' of github.com:cypress-io/cypress: Update packages/scaffold-config/src/detect.ts
mjhenkes
approved these changes
Jun 2, 2022
mjhenkes
approved these changes
Jun 2, 2022
…hub.com:cypress-io/cypress into tgriesser/fix/change-typescript-detection-rules * 'tgriesser/fix/change-typescript-detection-rules' of github.com:cypress-io/cypress: fix: do not watch specs on run mode (#22060) fix: #22038 support esm import for windows (#22042) fix: Change ffmpeg to post process at priority 20 (#21587)
ZachJW34
approved these changes
Jun 2, 2022
Contributor
ZachJW34
left a comment
There was a problem hiding this comment.
Ran through all the scenarios, works great.
| } | ||
|
|
||
| if ('typescript' in (pkgJson.dependencies || {}) || 'typescript' in (pkgJson.devDependencies || {})) { | ||
| // If we can't find an installed TypeScript or ESBuild, there's no way we can assume the project is using TypeScript, |
Contributor
There was a problem hiding this comment.
nit: or ESBuild I don't see anywhere we are checking for ESBuild
estrada9166
approved these changes
Jun 2, 2022
tgriesser
commented
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing changelog
typescriptactually exists (viarequire.resolve) and is specified independencies/devDependenciesbefore migrating a project to use it.*tsconfig.jsonglob, which should only happen when we're creating a new project, not migrating an existing one. If we're migrating, looking at the existing files in the cypress folder should be enough info to make the determination..d.tsfiles when making the determination of JS vs. TS projectAdditional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?