Skip to content

Fix mypy error when trying to update HeaderValueMatcher.DEFAULT_MATCHERS#94

Merged
csernazs merged 2 commits intocsernazs:masterfrom
MaxShvets:fix-mypy-error-when-setting-default-header-matcher
Jan 26, 2022
Merged

Fix mypy error when trying to update HeaderValueMatcher.DEFAULT_MATCHERS#94
csernazs merged 2 commits intocsernazs:masterfrom
MaxShvets:fix-mypy-error-when-setting-default-header-matcher

Conversation

@MaxShvets
Copy link
Copy Markdown
Contributor

This addresses #93.

@csernazs
Copy link
Copy Markdown
Owner

csernazs commented Jan 25, 2022

Thanks for the PR!

Could you please try it with MutableMapping? I think that the issue was that Mapping doesn't have __setitem__.
Theoretically speaking, I thing MutableMapping would cover it better but YMMV. If you don't think so (or you don't want to put the extra effort) then I'm happy to approve this in its current form, just let me know.

@MaxShvets
Copy link
Copy Markdown
Contributor Author

I think that the issue was that Mapping doesn't have setitem.

I think you're right. MutableMapping works, I pushed a new commit

@csernazs csernazs merged commit 55b776f into csernazs:master Jan 26, 2022
@MaxShvets MaxShvets deleted the fix-mypy-error-when-setting-default-header-matcher branch January 26, 2022 08:34
cailloumajor added a commit to cailloumajor/opcua-webhmi-bridge that referenced this pull request Jan 31, 2022
The typing error was fixed in pytest-httpserver v1.0.4.
See csernazs/pytest-httpserver#94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants