Skip to content

Reset estimator of progress rate on backwards movement#483

Merged
chris-laplante merged 3 commits intoconsole-rs:mainfrom
rlee287:est_reset_on_backstep
Sep 26, 2022
Merged

Reset estimator of progress rate on backwards movement#483
chris-laplante merged 3 commits intoconsole-rs:mainfrom
rlee287:est_reset_on_backstep

Conversation

@rlee287
Copy link
Copy Markdown
Contributor

@rlee287 rlee287 commented Sep 23, 2022

Implements a heuristic for ensuring that length finding via seeks does not disrupt the progress estimator.

Closes #480 .

@djc
Copy link
Copy Markdown
Member

djc commented Sep 23, 2022

Sorry, the test failure is unrelated (see #482).

@djc djc requested a review from chris-laplante September 26, 2022 07:59
@chris-laplante chris-laplante merged commit 14b5ef2 into console-rs:main Sep 26, 2022
@djc djc mentioned this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProgressBarIter and finding stream length via seeking breaks rate estimation

3 participants