Added support for Redaxo V 5.*#410
Merged
niksamokhvalov merged 5 commits intocomposer:masterfrom Aug 7, 2019
TheFehr:master
Merged
Added support for Redaxo V 5.*#410niksamokhvalov merged 5 commits intocomposer:masterfrom TheFehr:master
niksamokhvalov merged 5 commits intocomposer:masterfrom
TheFehr:master
Conversation
Contributor
Author
|
Will this be added or should I close this pull request? |
Contributor
Author
|
I had forgotten completely that I ever made this. I have since left the REDAXO scene and only install it now again to see the current state of affairs. Thanks for finishing the work! :-) |
Contributor
Author
|
@alcohol how do you decide on which pr's to merge? How can I improve this one? |
niksamokhvalov
requested changes
Aug 1, 2019
Contributor
Author
|
@niksamokhvalov I added the bestyle plugin intregration for both versions into the readme. How else can I improve this to get it merged? |
niksamokhvalov
approved these changes
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added new redaxo5-addon and redaxo5-bestyle-plugin types.