Codecov Report

Merging #145 into master will increase coverage by 0.19%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   89.36%   89.55%   +0.19%     
==========================================
  Files          21       22       +1     
  Lines         329      335       +6     
  Branches       80       82       +2     
==========================================
+ Hits          294      300       +6     
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8371836...0c57093. Read the comment docs.

@ChristianJacobsen @eddiemoore codecov detects properly Semaphore 2.x, but during the upload of the report to codecov I realised that it fails with the following error:

==> Uploading reports
--
  | HTTP 400
  | service must be ci-provider

Is there some whitelisting needed server side at codecov for the new service keys?

• semaphore2x
• semaphore1x

If so, we would better off reverting this merge and ship instead #132
This ones uses semaphore but drops compatibility with semaphore 1.x

Fixing in #146
Realise the service name should just be semaphore.

@fabiendem Please update to v3.6.1 and try again 👍

Testing... 🕐

✅ Great thanks @eddiemoore! It works now with #146 v3.6.1

==> Uploading reports
--
  | Success!
  | View report at: HTTP 200

And sorry about this, when I made my PR I wasn't aware of that constraint on the service name.

No worries. I wasn't aware either 😂 now we know