Update validation regex, pull checksums into script, and bump to 1.4.1#287
Merged
thomasrockhu merged 3 commits intomasterfrom Apr 20, 2021
Merged
Update validation regex, pull checksums into script, and bump to 1.4.1#287thomasrockhu merged 3 commits intomasterfrom
thomasrockhu merged 3 commits intomasterfrom
Conversation
3c7818c to
67a114e
Compare
67a114e to
95e6f30
Compare
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 97.07% 97.61% +0.54%
==========================================
Files 4 4
Lines 171 168 -3
Branches 49 47 -2
==========================================
- Hits 166 164 -2
+ Misses 5 4 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sbeidas
approved these changes
Apr 20, 2021
drazisil-codecov
approved these changes
Apr 20, 2021
drazisil-codecov
approved these changes
Apr 20, 2021
|
Thanks! |
ylemkimon
reviewed
Apr 24, 2021
| }; | ||
|
|
||
| export const retrieveChecksum = async (version, encryption) => { | ||
| const url = `https://raw.githubusercontent.com/codecov/codecov-bash/${version}/SHA${encryption}SUM`; |
There was a problem hiding this comment.
Please note the previous implementation has a flaw, as the version may contain .. (parent directory), so it can point to another repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the validation regex to restrict on digits and dots. Adds checksums into the script so that it doesn't do another request. Also bumps to 1.4.1