Skip to content

Fix for Libery running in "overlay"#415

Merged
lukehutch merged 1 commit into
classgraph:masterfrom
cpierceworld:liberty-fix
Apr 11, 2020
Merged

Fix for Libery running in "overlay"#415
lukehutch merged 1 commit into
classgraph:masterfrom
cpierceworld:liberty-fix

Conversation

@cpierceworld

Copy link
Copy Markdown
Contributor

Fix for LIberty issue #414

In this fix, I attempt to use the methods that just return the classpath urls. I can't regression test against any old Liberties so I have it fallback to the old logic whenever the new logic fails.

  • Use SmartClassPath's "getClassPath" to get the classpath URL(s).
  • If that doesn't work for some reason, revert to processing individual SmartClassPath elements.
    • Attempt to use "getContainerURLs" on SmartClassPath's elements
    • If that doesn't work, revert to introspection on the "container"
      • Attempt to use "getURls" on the container.
      • If that doesn't work, revert to introspection on the "delegate".

Use SmartClassPath's "getClassPath" to get the classpath URL(s).
@lukehutch lukehutch merged commit e7c80d8 into classgraph:master Apr 11, 2020
@lukehutch

Copy link
Copy Markdown
Member

Awesome, thanks for this work, @cpierceworld! I really appreciate your work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants