Skip to content

Deprecated sampleReservoir, samplePool, and sampleInsertion methods of SequenceSampler#275

Merged
cicirello merged 3 commits intomasterfrom
deprecate
Oct 16, 2022
Merged

Deprecated sampleReservoir, samplePool, and sampleInsertion methods of SequenceSampler#275
cicirello merged 3 commits intomasterfrom
deprecate

Conversation

@cicirello
Copy link
Owner

Summary

Deprecated the following:

  • The SequenceSampler.sampleReservoir methods, which are now replaced by the SequenceReservoirSampler class.
  • The SequenceSampler.samplePool methods, which are now replaced by the SequencePoolSampler class.
  • The SequenceSampler.sampleInsertion methods, which are now replaced by the SequenceInsertionSampler class.

Closing Issues

Closes #272
Closes #273
Closes #274

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvements to existing code, such as refactoring or optimizations (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link
Contributor

JaCoCo Test Coverage Summary Statistics

  • Coverage: 100%
  • Branches: 100%

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 16, 2022

⚠️ 1 God Class was detected by Lift in this project. Visit the Lift web console for more details.

@cicirello cicirello merged commit 75e9556 into master Oct 16, 2022
@cicirello cicirello deleted the deprecate branch October 16, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant