feat: added isTaxId#1336
Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom Jun 3, 2020
rubiin:master
Merged
Conversation
Member
Author
profnandaa
requested changes
May 31, 2020
Member
profnandaa
left a comment
There was a problem hiding this comment.
Looks good. Just one thing, please rewrite a little to support locales/contry-codes starting with US as default.
Member
Author
|
@profnandaa taxid is only valid for US as per wikipedia |
Member
|
I think other locations have equivalents, perhaps going by a different name... will be better to allow future expansion to other locales. |
Member
Author
|
sure |
Member
Author
|
@profnandaa i have added locales |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a validator to check taxid
addresses #1320
Checklist