Skip to content

Fix Typo#300

Merged
maaslalani merged 2 commits intocharmbracelet:masterfrom
yusufmalikul:patch-1
Jan 19, 2023
Merged

Fix Typo#300
maaslalani merged 2 commits intocharmbracelet:masterfrom
yusufmalikul:patch-1

Conversation

@yusufmalikul
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread paginator/paginator.go Outdated

// ItemsOnPage is a helper function for returning the numer of items on the
// ItemsOnPage is a helper function for returning the number of items on the
// current page given the total numer of items passed as an argument.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same typo is repeated in this line, as well as in table/table.go. Would be great to fix them all at once.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.
I fixed them too.

@yusufmalikul yusufmalikul requested a review from muesli December 4, 2022 02:21
@maaslalani maaslalani merged commit 3099851 into charmbracelet:master Jan 19, 2023
maaslalani added a commit that referenced this pull request Jan 19, 2023
This reverts commit 3099851.
@maaslalani
Copy link
Copy Markdown
Contributor

Sorry, made a type in the commit message 🤦, will leave it as I don't want to force push to master

ReallyLiri pushed a commit to ReallyLiri/bubbles that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants