File Read Shell Escape Issue#6
Merged
Merged
Conversation
Contributor
|
Thanks, @LuminousPath. |
|
Not yet @igorlamos , I have open my issue in #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey
I noticed that when trying to read in the gradle file, when I was using a regular string vs the string that was coming in from the
get_gradle_file_pathI wasn't getting errors likeInvalid argument @ rb_sysopenso I tried removing theshellescapeportion and it got rid of the errors.problem is (This might only be a windows thing)
shellescapecreates escaped double quotes:"\"C:/Users/Guy/Documents/Cool Project/project/android/build.gradle\""vs
"C:/Users/Guy/Documents/Cool Project/project/android/build.gradle"and so causes issues when File.open or File.new tries to read it. Also by design the
Fileclass doesn't need shell escaped strings.Made a pull request to fix it, not sure how many other people (if anyone) encountered this but it's a pretty straightforward fix