fix: Fixing issue with bump_type not working and version name not defaulting#14
Merged
Conversation
Updating to use default gradle path and bump_type
Adding tests for bump and default gradle version
Contributor
|
@jgsheffer shouldn’t we update the version in |
Contributor
Author
Good callout! I just got that pushed in. |
igorlamos
approved these changes
Mar 7, 2022
Contributor
|
@jgsheffer PR was merged ... I had to migrate the build job on Travis CI and it's failing now. Let me check & fix that and release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When no version name was passed in it would fill the version name as ""
bump_type was only being used when no version name was passed in
Changes