Disallow await as bound name in using declaration#15391
Merged
JLHwung merged 5 commits intobabel:mainfrom Feb 2, 2023
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53834/ |
a5a9380 to
097eb45
Compare
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "sourceType": "script" | |||
Member
There was a problem hiding this comment.
Can you also add a test in modules? It throws that await is reserved in modules, right?
nicolo-ribaudo
approved these changes
Feb 1, 2023
| "type": "File", | ||
| "start":0,"end":113,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":12,"column":1,"index":113}}, | ||
| "errors": [ | ||
| "SyntaxError: Can not use 'await' as identifier inside an async function. (2:8)", |
Member
There was a problem hiding this comment.
Unrelated, but this error message is wrong (we are not in an async function, but at the top-level of a module).
Contributor
Author
There was a problem hiding this comment.
We don't differentiate between module top level and async function as long as [Await] production parameter set. Maybe rephrase it as "Can not use 'await' as identifier inside an async context"?
liuxingbaoyu
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts by simplifying let-as-name binding checking, but then I realize that the
usingdeclaration has already banned binding patterns, which greatly simplifies the await-checking. Anyway I am pleased that we get rid of a parameter from the hot pathcheckIdentifier.