Falback to printing inner comments as trailing#15144
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Nov 7, 2022
Merged
Falback to printing inner comments as trailing#15144nicolo-ribaudo merged 2 commits intobabel:mainfrom
nicolo-ribaudo merged 2 commits intobabel:mainfrom
Conversation
nicolo-ribaudo
commented
Nov 5, 2022
Comment on lines
+9
to
+10
| C /* 2 */[] | ||
| /* 3 */; |
Member
Author
There was a problem hiding this comment.
/* 3 */ was not printed, this output was wrong!
It should be printed inside [], but we print [] as a single token. I'll open another PR for that.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53369/ |
liuxingbaoyu
approved these changes
Nov 6, 2022
JLHwung
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.