Skip to content

Add deno compilation target#14944

Merged
nicolo-ribaudo merged 3 commits into
babel:mainfrom
JLHwung:add-deno-compat-data
Oct 26, 2022
Merged

Add deno compilation target#14944
nicolo-ribaudo merged 3 commits into
babel:mainfrom
JLHwung:add-deno-compat-data

Conversation

@JLHwung

@JLHwung JLHwung commented Sep 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
Q                       A
Fixed Issues? support deno as a compilation target
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link babel/website#2680
Any Dependency Changes?
License MIT

In this PR we add deno compat data sourced from the compat-table. Now preset-env recognizes deno as a compilation target:

{
  "presets": [["env", { "targets": { "deno": "1.0" } }]]
}

Unlike node, deno: "current" is not yet supported because Babel does not support deno.

@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: compat-data labels Sep 16, 2022
@JLHwung JLHwung added this to the 7.20.0 milestone Sep 16, 2022
@babel-bot

babel-bot commented Sep 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53250/

@liuxingbaoyu liuxingbaoyu added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Sep 17, 2022
@zloirock

zloirock commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What about adding Hermes that's in compat-table and core-js-compat for a long time?

@zloirock

zloirock commented Sep 19, 2022

Copy link
Copy Markdown
Member

#14831

liuxingbaoyu
liuxingbaoyu reviewed Oct 26, 2022
View reviewed changes
Comment thread packages/babel-preset-env/test/fixtures/preset-options/deno-1_0/output.js Outdated
@JLHwung

JLHwung commented Oct 26, 2022

Copy link
Copy Markdown
Contributor Author

✔️ for the recent rebase. @liuxingbaoyu Thanks.

@nicolo-ribaudo nicolo-ribaudo merged commit 745eacc into babel:main Oct 26, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the add-deno-compat-data branch October 26, 2022 19:37
@shaneomatz shaneomatz mentioned this pull request Nov 18, 2022
Open
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 26, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes
@existentialism existentialism existentialism approved these changes
@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: compat-data PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release

Projects

None yet

Milestone

7.20.0

Development

Successfully merging this pull request may close these issues.

6 participants

@JLHwung @babel-bot @zloirock @existentialism @nicolo-ribaudo @liuxingbaoyu