Skip to content

fix: jsx with retainLines#14869

Merged
JLHwung merged 1 commit intobabel:mainfrom
liuxingbaoyu:fix-jsx-retainLines
Aug 22, 2022
Merged

fix: jsx with retainLines#14869
JLHwung merged 1 commit intobabel:mainfrom
liuxingbaoyu:fix-jsx-retainLines

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

@liuxingbaoyu liuxingbaoyu commented Aug 22, 2022 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues? Fixes #14868
Patch: Bug Fix? √
Tests Added + Pass? √
License MIT

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator i: regression area: jsx labels Aug 22, 2022
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Aug 22, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52749/

@JLHwung JLHwung merged commit 14c3f12 into babel:main Aug 22, 2022
@liuxingbaoyu liuxingbaoyu deleted the fix-jsx-retainLines branch August 22, 2022 23:23
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

area: jsx i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Extra newlines added to JSX with retainLines option

4 participants

@liuxingbaoyu @babel-bot @JLHwung @nicolo-ribaudo