Let path.remove() remove IfStatement.alternate#14833
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Aug 16, 2022
Merged
Let path.remove() remove IfStatement.alternate#14833nicolo-ribaudo merged 3 commits intobabel:mainfrom
path.remove() remove IfStatement.alternate#14833nicolo-ribaudo merged 3 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52717/ |
Member
|
Tip: Currently our active branch is |
Contributor
|
Can you rebase on the |
Special-casing "consequent" makes sense, but there is no need to deviate from the normal `remove()` behavior for "alternate", which is permitted to be null.
Contributor
Author
|
Ah, I didn't realize GitHub didn't do that automatically. Updated! |
JLHwung
reviewed
Aug 8, 2022
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
Thanks! Can you add a new test case to packages/babel-traverse/test/removal.js?
One test verifies the behavior fixed in babel#3583 (removing consequent does not make it null) and the other babel#14833 (removing alternate *does* make it null).
liuxingbaoyu
approved these changes
Aug 9, 2022
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
path.remove() remove IfStatement.alternate
JLHwung
added a commit
to JLHwung/babel
that referenced
this pull request
Aug 16, 2022
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing a transformation plugin, I would expect calling
remove()on anelseclause to remove theelse, not replace it with an empty block. Special-casing "consequent" makes sense, because it is not permitted to be null, but there is no need to deviate from the normalremove()behavior for "alternate".Let me know if tests are needed for this since it's a small change.