Skip to content

chore(traverse): fix some internal typescript types#14821

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
danez:ts-traverse-fix
Aug 3, 2022
Merged

chore(traverse): fix some internal typescript types#14821
nicolo-ribaudo merged 1 commit intobabel:mainfrom
danez:ts-traverse-fix

Conversation

@danez
Copy link
Copy Markdown
Member

@danez danez commented Aug 2, 2022

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change? no
Minor: New Feature? no
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes? no
License MIT

I recently fixed the types in DefinitelyTyped and found that some of the babel internal types are also not optimal. So here is a PR to fix them.

@danez danez added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: traverse area: typescript labels Aug 2, 2022
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52664/

Copy link
Copy Markdown
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit a196459 into babel:main Aug 3, 2022
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 3, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants