babel parser type improvements#14801
Merged
liuxingbaoyu merged 6 commits intobabel:mainfrom Aug 3, 2022
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52628/ |
zxbodya
commented
Jul 26, 2022
Comment on lines
-3149
to
+3154
| return super.checkParams(node, allowDuplicates, isArrowFunction); | ||
| return super.checkParams( | ||
| node, | ||
| allowDuplicates, | ||
| isArrowFunction, | ||
| strictModeChanged, | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
here, interestingly - last argument was missing(comparing to overridden method signature)
liuxingbaoyu
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type improvements for babel parser:
...argsin class methods, replacing it with actual arguments(rebasing remaining type fixes from #13370)