Fix position of errors in template literals after newlines#14798
Merged
nicolo-ribaudo merged 2 commits intoJul 26, 2022
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52616/ |
0d1b983 to
cfadbfe
Compare
JLHwung
approved these changes
Jul 26, 2022
Contributor
|
Does this happen to fix this? #14146 |
existentialism
approved these changes
Jul 26, 2022
Member
Author
|
@tolmasky No, but I'll take a look at it since it feels related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #14772 (the first commit shows the wrong behavior, the second one fixes it). We always need to carry around
lineStartandcurLine, because they are needed to compute the error position.