Skip to content

enable typescript incremental builds#14790

Merged
JLHwung merged 1 commit into
babel:mainfrom
zxbodya:ts-incremental-builds
Jul 24, 2022
Merged

enable typescript incremental builds#14790
JLHwung merged 1 commit into
babel:mainfrom
zxbodya:ts-incremental-builds

Conversation

@zxbodya

@zxbodya zxbodya commented Jul 23, 2022

Copy link
Copy Markdown
Contributor

this is to make running tsc locally faster
(for me it is almost 10x improvement - reducing it from 40 to around 4 seconds)

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

this is to make running tsc locally faster(for me it around 10x improvement shorting it from 40 to 4 seconds)
@babel-bot

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52595/

@liuxingbaoyu

Copy link
Copy Markdown
Member

May I ask what command are you using? We only seem to use tsc with make prepublish-build.

This PR looks good to me though.

@liuxingbaoyu liuxingbaoyu added PR: Internal 🏠 A type of pull request used for our changelog categories area: typescript labels Jul 23, 2022
@zxbodya

zxbodya commented Jul 23, 2022

Copy link
Copy Markdown
Contributor Author

May I ask what command are you using? We only seem to use tsc with make prepublish-build.

yarn tsc (and time yarn tsc to measure the time it takes)

@JLHwung JLHwung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@JLHwung JLHwung merged commit 6af3ba7 into babel:main Jul 24, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the ts-incremental-builds branch July 24, 2022 05:58
@nicolo-ribaudo

Copy link
Copy Markdown
Member

@liuxingbaoyu You can also run it locally with make tscheck

@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 24, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants