Default to hash syntax for Record&Tuple#14744
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Sep 2, 2022
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52732/ |
rricard
approved these changes
Jul 8, 2022
liuxingbaoyu
approved these changes
Jul 8, 2022
nicolo-ribaudo
commented
Jul 8, 2022
| @@ -1 +0,0 @@ | |||
| #{ a: 1 } | |||
Member
Author
There was a problem hiding this comment.
I should restore this test and show that is doesn't throw anymore.
JLHwung
approved these changes
Jul 8, 2022
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
Can you also update packages/babel-parser/typings/babel-parser.d.ts?
JLHwung
approved these changes
Jul 8, 2022
Contributor
|
Can you also open a Docs PR for https://babeljs.io/docs/en/babel-parser#plugins-options? |
1f695dd to
c6ebb2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposal settled on
#cc @rricard @acutmore