fix: deep clone shared AST field definitions#14737
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Jul 8, 2022
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52448/ |
liuxingbaoyu
approved these changes
Jul 7, 2022
nicolo-ribaudo
approved these changes
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared AST field definitions could be mutated by
babel/packages/babel-types/src/definitions/utils.ts
Lines 344 to 346 in 1c79224
This issue surfaced when I am reviewing https://github.com/babel/babel/pull/14730/files#diff-85c1fccaeecd3c19b928ca56b3730ba55d198ce4e61717f56fc6a6aa62a7f85fL1043, where the
kindof ClassPrivateMethod changed from an optional property to a non-optional property (expected). Here we deep clone the shared definitions such that, for example, mutatingTSPropertySignature'scomputeddoes not affectClassMethod's.