Fix compilation of nested super(...) calls#14709
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Jul 1, 2022
dbacarel:fix-multiple-super-calls
Merged
Fix compilation of nested super(...) calls#14709nicolo-ribaudo merged 3 commits intobabel:mainfrom dbacarel:fix-multiple-super-calls
super(...) calls#14709nicolo-ribaudo merged 3 commits intobabel:mainfrom
dbacarel:fix-multiple-super-calls
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52417/ |
Member
|
I edited your description adding "Fixes" before the issue number. By doing so, it will be automatically closed when this PR is merged 🙂 |
Member
|
The failing tests is a network error, I'll restart it. |
Contributor
Author
oh right, thanks! |
JLHwung
approved these changes
Jun 30, 2022
| } | ||
|
|
||
| const bareSupers = new Set<NodePath<t.CallExpression>>(); | ||
| const bareSupers = new Array<NodePath<t.CallExpression>>(); |
Contributor
There was a problem hiding this comment.
Nit:
Suggested change
| const bareSupers = new Array<NodePath<t.CallExpression>>(); | |
| const bareSupers: NodePath<t.CallExpression>[] = []; |
will be shorter.
Member
There was a problem hiding this comment.
Also, new Array is usually considered badTM because as soon as you start passing arguments to it it has inconsistent behaviors.
liuxingbaoyu
approved these changes
Jul 1, 2022
super(...) calls
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug along with the fix are described in details in the issue. No need to duplicate I think .