fix: preserve function params type if possible#14694
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Jun 27, 2022
magic-akari:fix/issue-14691
Merged
fix: preserve function params type if possible#14694nicolo-ribaudo merged 2 commits intobabel:mainfrom magic-akari:fix/issue-14691
nicolo-ribaudo merged 2 commits intobabel:mainfrom
magic-akari:fix/issue-14691
Conversation
liuxingbaoyu
approved these changes
Jun 26, 2022
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I dislike hard-coding TS/Flow AST info in "plain JS" plugins, but until we have something like #9545 this is the best we can do.
Member
|
Can you also add a test for |
Contributor
Author
Sure. I dont' think there is anything to do if the function parameter doesn't exist. |
Contributor
Author
|
Since the function param with default value does not count in function length, we should never add param placeholder for it. |
Member
|
Oh right, I don't know what I was thinking |
nicolo-ribaudo
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.