Skip to content

Support private name in decorator member expression#14666

Merged
JLHwung merged 1 commit intobabel:feat-7.19.0/decoratorsfrom
JLHwung:support-private-name-in-decorator-member-expression
Aug 16, 2022
Merged

Support private name in decorator member expression#14666
JLHwung merged 1 commit intobabel:feat-7.19.0/decoratorsfrom
JLHwung:support-private-name-in-decorator-member-expression

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Jun 13, 2022 •
edited
Loading

Q                       A
Fixed Issues? Supports parsing decorator expressions such as @C.#dec
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

Currently pending tc39/ecma262#2417 (comment).

@JLHwung JLHwung added PR: Spec Compliance 👓 A type of pull request used for our changelog categories pkg: parser Spec: Decorators labels Jun 13, 2022
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Jun 13, 2022 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52725/

@JLHwung JLHwung force-pushed the support-private-name-in-decorator-member-expression branch from 4e73b20 to 743b3f0 Compare June 14, 2022 13:19
@JLHwung JLHwung mentioned this pull request Aug 8, 2022
Merged
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Aug 16, 2022
Merged
3 tasks
@JLHwung JLHwung force-pushed the support-private-name-in-decorator-member-expression branch 2 times, most recently from 5eb48a1 to 822d5fd Compare August 16, 2022 13:44
@JLHwung JLHwung changed the base branch from main to feat-7.19.0/decorators August 16, 2022 13:44
@JLHwung JLHwung marked this pull request as ready for review August 16, 2022 13:44
@JLHwung JLHwung force-pushed the support-private-name-in-decorator-member-expression branch from 822d5fd to 0a98614 Compare August 16, 2022 13:45
@JLHwung JLHwung merged commit 7006391 into babel:feat-7.19.0/decorators Aug 16, 2022
@JLHwung JLHwung deleted the support-private-name-in-decorator-member-expression branch August 16, 2022 17:15
nicolo-ribaudo pushed a commit that referenced this pull request Aug 24, 2022
@JLHwung @nicolo-ribaudo
support private name in decorator member expr (#14666)
4d69407
nicolo-ribaudo pushed a commit that referenced this pull request Aug 24, 2022
@JLHwung @nicolo-ribaudo
support private name in decorator member expr (#14666)
08bd28c
nicolo-ribaudo pushed a commit that referenced this pull request Sep 2, 2022
@JLHwung @nicolo-ribaudo
support private name in decorator member expr (#14666)
a91c3d2
nicolo-ribaudo pushed a commit that referenced this pull request Sep 2, 2022
@JLHwung @nicolo-ribaudo
support private name in decorator member expr (#14666)
1aa04a2
nicolo-ribaudo pushed a commit that referenced this pull request Sep 5, 2022
@JLHwung @nicolo-ribaudo
support private name in decorator member expr (#14666)
85ce832
@shaneomatz shaneomatz mentioned this pull request Nov 18, 2022
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Decorators

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JLHwung @babel-bot @nicolo-ribaudo @liuxingbaoyu