[ts] Disallow property access after instantiation expression#14650
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Jun 27, 2022
Merged
[ts] Disallow property access after instantiation expression#14650nicolo-ribaudo merged 3 commits intobabel:mainfrom
nicolo-ribaudo merged 3 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52375/ |
Member
Author
|
The TS PR has been merged. |
liuxingbaoyu
approved these changes
Jun 26, 2022
JLHwung
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm marking this as a draft until we see the actual implementation from the TS team.
@armano2 I think that after this PR we can close #14613 as "working as intended": since an instantiation expression can never appear in the middle of the chain, we can easily represent it as
TSInstantiationExpression > OptionalMemberExpression(which is what we currently do).