Skip to content

fix: loc.index of some nodes is wrongly enumerable.#14595

Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom
liuxingbaoyu:fix-loc-index
May 26, 2022
Merged

fix: loc.index of some nodes is wrongly enumerable.#14595
nicolo-ribaudo merged 2 commits intobabel:mainfrom
liuxingbaoyu:fix-loc-index

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

@liuxingbaoyu liuxingbaoyu commented May 25, 2022

Q                       A
Fixed Issues? Fixes #14590
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes?
License MIT

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

There is a small change for performance in packages/babel-helper-check-duplicate-nodes/src/index.ts.

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: typescript labels May 25, 2022
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented May 25, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52031/

Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test update!

@nicolo-ribaudo nicolo-ribaudo merged commit 8967ccb into babel:main May 26, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: parser(ts), ast, TSTypePredicate and TSEnumDeclaration returns additional index property in loc.start

4 participants