Skip to content

feat: Automatically generate test results that do not exist#14592

Merged
JLHwung merged 3 commits intobabel:mainfrom
liuxingbaoyu:improve-parser-test
May 31, 2022
Merged

feat: Automatically generate test results that do not exist#14592
JLHwung merged 3 commits intobabel:mainfrom
liuxingbaoyu:improve-parser-test

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

@liuxingbaoyu liuxingbaoyu commented May 25, 2022 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

nicolo-ribaudo
nicolo-ribaudo approved these changes May 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used to work a few months ago, but I when it stopped I wasn't annoyed enough to fix it. Thank you!

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented May 25, 2022 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52098/

@JLHwung
Copy link
Copy Markdown
Contributor

JLHwung commented May 27, 2022

Can you update the Babel 8 test fixtures?

@liuxingbaoyu liuxingbaoyu force-pushed the improve-parser-test branch from 75c1448 to 4375221 Compare May 27, 2022 14:09
@liuxingbaoyu
Copy link
Copy Markdown
Member Author

liuxingbaoyu commented May 27, 2022

Oops, there was an exception in the main branch.

@liuxingbaoyu liuxingbaoyu added PR: Internal 🏠 A type of pull request used for our changelog categories PR: Fixes failing main and removed PR: Internal 🏠 A type of pull request used for our changelog categories labels May 27, 2022
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request May 28, 2022
Closed
@liuxingbaoyu liuxingbaoyu force-pushed the improve-parser-test branch 2 times, most recently from 4375221 to d256261 Compare May 31, 2022 20:04
@liuxingbaoyu
Copy link
Copy Markdown
Member Author

liuxingbaoyu commented May 31, 2022

@JLHwung Can you take a look at this?

@JLHwung JLHwung merged commit dd75b02 into babel:main May 31, 2022
@JLHwung JLHwung added area: tests PR: Internal 🏠 A type of pull request used for our changelog categories labels May 31, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 31, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liuxingbaoyu @babel-bot @JLHwung @existentialism @nicolo-ribaudo