fix: remove TSDeclareFunction from ExportDefaultDeclaration#14591
Merged
JLHwung merged 1 commit intobabel:mainfrom May 26, 2022
Merged
fix: remove TSDeclareFunction from ExportDefaultDeclaration#14591JLHwung merged 1 commit intobabel:mainfrom
JLHwung merged 1 commit intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52023/ |
Member
|
Did we also support this in the parser? |
Contributor
Author
No. Tested on Babel parser 7.13 and it throws "Missing semicolon (1:22)" after |
existentialism
approved these changes
May 25, 2022
nicolo-ribaudo
approved these changes
May 25, 2022
Contributor
Author
|
CI error is not related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike
export declare function f(),export default declare function f()is not valid TS and therefore we should remove it fromExportDefaultDeclaration.Babel parser throws on
export default declare function f(), too.