Skip to content

fix: Duplicate declaration in transformed for...of#14564

Merged
nicolo-ribaudo merged 4 commits intobabel:mainfrom
liuxingbaoyu:fix-for-of
May 19, 2022
Merged

fix: Duplicate declaration in transformed for...of#14564
nicolo-ribaudo merged 4 commits intobabel:mainfrom
liuxingbaoyu:fix-for-of

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

@liuxingbaoyu liuxingbaoyu commented May 19, 2022 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues? Fixes #14379, Fixes #11920
Patch: Bug Fix? √
Major: Breaking Change? ×
Minor: New Feature? ×
Tests Added + Pass? √
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented May 19, 2022 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51974/

@liuxingbaoyu liuxingbaoyu marked this pull request as draft May 19, 2022 11:43
@liuxingbaoyu
Copy link
Copy Markdown
Member Author

liuxingbaoyu commented May 19, 2022

No fix due to missing tests in no-helper-implementation.ts.

@liuxingbaoyu liuxingbaoyu marked this pull request as ready for review May 19, 2022 12:05
@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented May 19, 2022

I would be ok with saying that no-helper-implementation.ts doesn't receive any bug fix. That implementation is only used with very old @babel/core versions, so users can easily switch to the new/better implementation with a simple upgrade.

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label May 19, 2022
nicolo-ribaudo
nicolo-ribaudo approved these changes May 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

JLHwung
JLHwung approved these changes May 19, 2022
View reviewed changes
JLHwung
JLHwung reviewed May 19, 2022
View reviewed changes
@nicolo-ribaudo nicolo-ribaudo merged commit 44362f4 into babel:main May 19, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate declaration in transformed for...of Repl error – Duplicate declaration – when using the same let-variable in for-of loop

4 participants

@liuxingbaoyu @babel-bot @nicolo-ribaudo @JLHwung