Skip to content

Print necessary parentheses for functions in postfix expressions#14532

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
xiawenqi:main
May 6, 2022
Merged

Print necessary parentheses for functions in postfix expressions#14532
nicolo-ribaudo merged 1 commit intobabel:mainfrom
xiawenqi:main

Conversation

@xiawenqi
Copy link
Copy Markdown
Contributor

@xiawenqi xiawenqi commented May 6, 2022

Q                       A
Fixed Issues? Fixes #14401
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

fix the problem (function (){}).x++ doesn't correctly generate parentheses, previously generate function () { return {x: 24} }().x++;

@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51861/

1 similar comment
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51861/

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator labels May 6, 2022
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The ci failure is not related.

@nicolo-ribaudo nicolo-ribaudo merged commit 0984a2a into babel:main May 6, 2022
@nicolo-ribaudo nicolo-ribaudo changed the title fix: isFirstInContext doesn't handle postfix unary operators Print necessary parentheses for functions in postfix expressions May 6, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Function Statements Require a Function Name

4 participants